Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different lib to render qr code, also render it to svg instead of canvas. #38

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Use different lib to render qr code, also render it to svg instead of canvas. #38

merged 5 commits into from
Apr 11, 2024

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Apr 11, 2024 •
edited
Loading

  • rendering to svg solves the qr code rendering problem on firefox
  • the lib we use now aims to be the most correct library: https://github.com/nayuki/QR-Code-generator
  • Bonus: This change saves 7kb on every page load.
  • the minimum target of the website is ist es5/es2015 (javascript version)

@Simon-Laux
Use different lib to render qr code, also render it to svg instead of…
e0059e4 
… canvas.

- rendering to svg solves the qr code rendering problem on firefox
- the lib we use now aims to be the most correct library: https://github.com/nayuki/QR-Code-generator
- Bonus: This change saves 7kb on very page load.
- the minimum target of the website is ist es5/es2015 (javascript version)
@Simon-Laux Simon-Laux requested a review from r10s April 11, 2024 16:33
r10s
r10s approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

what a sharpness 🔪

@Simon-Laux Simon-Laux merged commit de60f7d into main Apr 11, 2024
2 checks passed
@Simon-Laux Simon-Laux deleted the simon/use-a-different-qrcode-generator-lib-that-renders-to-svg branch April 11, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Simon-Laux @r10s